Improve support for adding public keys for deploys #1344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swalkinshaw
changed the title
swalkinshaw
commented
Dec 29, 2021
| @@ -55,7 +55,7 @@ def replace_item_with_key(obj, result): | |||
| ) | |||
|
|
|||
| if should_replace: | |||
| if 'key' in result._result[item]: | |||
There was a problem hiding this comment.
This PR exposed a bug in this code since result._result[item] was a string containing "key" (in public_keys) and Python's in operator is flexible for dict keys or substrings.
Adding a deploy specific SSH public key to a Trellis server is a common task to enable CI/CD deploys (such as GitHub Actions). This creates a standard folder (`public_keys`) for them. Any public SSH keys in that folder (ending in `.pub`) will be automatically added to the `web_user` as an authorized key.
swalkinshaw
force-pushed
the
add-deploy-public-keys
branch
from
3e1374d
to
5b6a295
Compare
retlehs
approved these changes
Dec 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a deploy specific SSH public key to a Trellis server is a common task to enable CI/CD deploys (such as GitHub Actions).
This creates a standard folder (
public_keys) for them. Any public SSH keys in that folder (ending in.pub) will be automatically added to theweb_useras an authorized key.